linux-kernel - Re: [PATCH 2/4] arm64: dts: rockchip: rockpro64 dts remove unused node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <468cbdb5-954a-bb1b-106f-14e387f6781f@mentor.com>
Date:   Sat, 16 Feb 2019 20:50:55 +0530
From:   agajjar <Akash_Gajjar@...tor.com>
To:     Heiko Stübner <heiko@...ech.de>
CC:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Oskari Lemmela <oskari@...mela.net>,
        Shohei Maruyama <cheat.sc.linux@...look.com>,
        Levin Du <djw@...hip.com.cn>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-rockchip@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/4] arm64: dts: rockchip: rockpro64 dts remove unused
 node

On 2/16/2019 2:16 AM, Heiko Stübner wrote:
> Am Freitag, 15. Februar 2019, 13:08:16 CET schrieb agajjar:
>> On 2/15/2019 2:48 PM, Heiko Stübner wrote:
>>> Am Mittwoch, 13. Februar 2019, 18:06:38 CET schrieb Akash Gajjar:
>>>> lcd panel pinmux and vcc1v8_s3 regulator is redundant and has a no
>>>> impact,
>>>> so removing it.
>>>>
>>>> Signed-off-by: Akash Gajjar <Akash_Gajjar@...tor.com>
>> Hi Heiko,
>>
>>> vcc1v8_s3 is actually also a emmc supply, so I'd like to keep it around
>>> for completenes sake.
>> Emmc module is supplied by PMIC vcc3v3_s3 (SWITCH_REG1) and vcc_1v8
>> (DCD_REG4).
>>
>> So I believe removing vcc1v8_s3 has no impact on emmc supply line.
> looking at the rockpro64 schematics page 10, I see vcca1v8_s3 linked
> to the emmc_vdd_1v8 input and obviously also as reference for the saradc.

You are referring Pilot production release (rockpro64_v20-SCH.pdf), 
please refer Second batch production release (rockpro64_v21-SCH.pdf).

both the schematic release is available at 
http://wiki.pine64.org/index.php/ROCKPro64_Main_Page

>
> So I think we really could keep it around, so that the power-tree resembles
> the schematics more.

Thanks,

Akash