linux-kernel - Re: [PATCH v4 33/37] ARM: davinci: cp-intc: use readl/writel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 17 Feb 2019 11:01:05 +0100
From:   David Lechner <david@...hnology.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Sekhar Nori <nsekhar@...com>,
        Kevin Hilman <khilman@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <marc.zyngier@....com>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: Re: [PATCH v4 33/37] ARM: davinci: cp-intc: use
 readl/writel_relaxed()

On 2/14/19 8:52 AM, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@...libre.com>
> 
> Raplace all calls to __raw_readl() & __raw_writel() with readl_relaxed()

s/Raplace/Replace/

> and writel_relaxed() respectively. It's safe to do as there's no
> endianness conversion being done in the code.

Should this be combined with patch 14/37?

> 
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com>
> ---
>   arch/arm/mach-davinci/cp_intc.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-davinci/cp_intc.c b/arch/arm/mach-davinci/cp_intc.c
> index 1bf11fa8be76..f88b7f0978aa 100644
> --- a/arch/arm/mach-davinci/cp_intc.c
> +++ b/arch/arm/mach-davinci/cp_intc.c
> @@ -45,13 +45,13 @@ static struct irq_domain *davinci_cp_intc_irq_domain;
>   
>   static inline unsigned int davinci_cp_intc_read(unsigned int offset)
>   {
> -	return __raw_readl(davinci_cp_intc_base + offset);
> +	return readl_relaxed(davinci_cp_intc_base + offset);
>   }
>   
>   static inline void davinci_cp_intc_write(unsigned long value,
>   					 unsigned int offset)
>   {
> -	__raw_writel(value, davinci_cp_intc_base + offset);
> +	writel_relaxed(value, davinci_cp_intc_base + offset);
>   }
>   
>   static void davinci_cp_intc_ack_irq(struct irq_data *d)
>