linux-kernel - Re: [PATCH] ARM: dts: rockchip: add chosen node on veyron chromebooks

Open Source and information security mailing list archives

Message-ID: <CAFqH_50ydkQWYbgRZX=nYMb-Goe5mT30yUbKNisqmQcj=-tOSw@mail.gmail.com>
Date:   Sun, 17 Feb 2019 21:38:32 +0100
From:   Enric Balletbo Serra <eballetbo@...il.com>
To:     Heiko Stuebner <heiko@...ech.de>
Cc:     Alexandru M Stan <amstan@...omium.org>,
        Mark Rutland <mark.rutland@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Doug Anderson <dianders@...omium.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        Rob Herring <robh+dt@...nel.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        kernel@...labora.com,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] ARM: dts: rockchip: add chosen node on veyron chromebooks

Hi,
Missatge de Heiko Stuebner <heiko@...ech.de> del dia ds., 16 de febr.
2019 a les 21:28:
>
> Am Samstag, 16. Februar 2019, 02:13:25 CET schrieb Alexandru M Stan:
> > On Fri, Feb 15, 2019 at 3:09 PM Heiko Stübner <heiko@...ech.de> wrote:
> > >
> > > Hi Enric,
> > >
> > > Am Freitag, 15. Februar 2019, 12:51:50 CET schrieb Enric Balletbo i Serra:
> > > > In order to use earlycon, the stdout-path property needs to be set
> > > > in the chosen node.
> > > >
> > > > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> > >
> > > What's the reason for adding this only for the Chromebook variants?
> > > Uart2 is pretty much the standard output for all devices, so I'd assume
> > > at least all veyron boards should use uart2 as well, making this ideally
> > > live in the rk3288-veyron.dtsi instead?
> >
> > Yep, all veyriants use uart 2, even when they're not chromebooks.
> > Feel free to put it in the other file instead.
> >
> > Otherwise it'll make things like the Asus Chromebit (mickey), AOpen
> > Chromebox mini (fievel), and AOpen Chromebase (tiger) unhappy
> > while debugging.
> >
> > The rk3288-veyron-chromebook.dtsi file is more for things that make
> > a chromebook portable. Ex: built in display, lid switch, cros-ec.
> >
> > Note how we have no uart2 references either in our tree in the
> > chromebook specific dtsi:
> > https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-3.14/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
>
> thanks for the confirmation :-) .
>
> I've moved the choosen node over to veyron.dtsi and applied the result
> for 5.1
>

Perfect thanks, I was unsure about the non-chromebooks devices.

> Thanks
> Heiko
>
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives