linux-kernel - Re: [PATCH] Input: st1232 - include gpio/consumer.h header for gpiod_set_value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190217053503.GC107793@dtor-ws>
Date:   Sat, 16 Feb 2019 21:35:03 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Martin Kepplinger <martink@...teo.de>
Cc:     kuninori.morimoto.gx@...esas.com, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: st1232 - include gpio/consumer.h header for
 gpiod_set_value_cansleep()

On Wed, Feb 13, 2019 at 12:19:58PM +0100, Martin Kepplinger wrote:
> gpiod_set_value_cansleep() needs it's declaration in the corresponding
> header. This fixes build errors like
> 
>    drivers/input/touchscreen/st1232.c: In function 'st1232_ts_power':
> >> drivers/input/touchscreen/st1232.c:146:3: error: implicit declaration of
>    function 'gpiod_set_value_cansleep'; did you mean 'gpio_set_value_cansleep'?
>    [-Werror=implicit-function-declaration]
>       gpiod_set_value_cansleep(ts->reset_gpio, !poweron);
>       ^~~~~~~~~~~~~~~~~~~~~~~~
>       gpio_set_value_cansleep
> 
> Signed-off-by: Martin Kepplinger <martink@...teo.de>

Thanks Martin, I'll fold it into the original patch introducing gpiod so
we keep bisectability.

-- 
Dmitry