linux-kernel - Re: [PATCH] powerpc/64s: Fix possible corruption on big endian due to pgd/pud

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h8d2ddmy.fsf@concordia.ellerman.id.au>
Date:   Sun, 17 Feb 2019 19:26:29 +1100
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Andreas Schwab <schwab@...ux-m68k.org>
Cc:     linuxppc-dev@...abs.org, linux-mm@...ck.org, erhard_f@...lbox.org,
        jack@...e.cz, aneesh.kumar@...ux.vnet.ibm.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powerpc/64s: Fix possible corruption on big endian due to pgd/pud_present()

Andreas Schwab <schwab@...ux-m68k.org> writes:

> On Feb 14 2019, Michael Ellerman <mpe@...erman.id.au> wrote:
>
>> The fix is simple, we need to convert the result of the bitwise && to
>> an int before returning it.
>
> Alternatively, the return type could be changed to bool, so that the
> compiler does the right thing by itself.

Yes that would be preferable. All other architectures return an int so
I wasn't game to switch to bool for a fix. But I don't see why it should
matter so I'll do a patch using bool for next.

cheers