linux-kernel - Re: [PATCH 4.20 71/92] Revert "mm: slowly shrink slabs with a relatively small number of objects"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190218161634.GA30873@kroah.com>
Date:   Mon, 18 Feb 2019 17:16:34 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Rik van Riel <riel@...riel.com>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Dave Chinner <dchinner@...hat.com>,
        Wolfgang Walter <linux@...m.de>, Roman Gushchin <guro@...com>,
        Spock <dairinin@...il.com>, Michal Hocko <mhocko@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 4.20 71/92] Revert "mm: slowly shrink slabs with a
 relatively small number of objects"

On Mon, Feb 18, 2019 at 10:30:44AM -0500, Rik van Riel wrote:
> On Mon, 2019-02-18 at 14:43 +0100, Greg Kroah-Hartman wrote:
> > 4.20-stable review patch.  If anyone has any objections, please let
> > me know.
> > 
> > ------------------
> > 
> > From: Dave Chinner <dchinner@...hat.com>
> > 
> > commit a9a238e83fbb0df31c3b9b67003f8f9d1d1b6c96 upstream.
> > 
> > This reverts commit 172b06c32b9497 ("mm: slowly shrink slabs with a
> > relatively small number of objects").
> 
> This revert will result in the slab caches of dead
> cgroups with a small number of remaining objects never
> getting reclaimed, which can be a memory leak in some
> configurations.
> 
> But hey, that's your tradeoff to make.

That's what is in Linus's tree.  Should we somehow diverge from that?

thanks,

greg k-h