lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 18 Feb 2019 08:34:12 -0800
From:   tip-bot for Shaokun Zhang <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     imammedo@...hat.com, tglx@...utronix.de, puwen@...on.cn,
        x86@...nel.org, suravee.suthikulpanit@....com, bp@...e.de,
        mingo@...hat.com, zhenzhong.duan@...cle.com, mingo@...nel.org,
        yazen.ghannam@....com, linux-kernel@...r.kernel.org,
        zhangshaokun@...ilicon.com, konrad.wilk@...cle.com,
        rppt@...ux.vnet.ibm.com, hpa@...or.com, alison.schofield@...el.com
Subject: [tip:x86/cleanups] x86/smpboot: Remove unused phys_id variable

Commit-ID:  f91fecc09e498529230b4d5053cb361619a0c42d
Gitweb:     https://git.kernel.org/tip/f91fecc09e498529230b4d5053cb361619a0c42d
Author:     Shaokun Zhang <zhangshaokun@...ilicon.com>
AuthorDate: Mon, 18 Feb 2019 21:05:01 +0800
Committer:  Borislav Petkov <bp@...e.de>
CommitDate: Mon, 18 Feb 2019 17:09:24 +0100

x86/smpboot: Remove unused phys_id variable

The 'phys_id' local variable became unused after commit

  ce4b1b16502b ("x86/smpboot: Initialize secondary CPU only if master CPU will wait for it").

Remove it.

Signed-off-by: Shaokun Zhang <zhangshaokun@...ilicon.com>
Signed-off-by: Borislav Petkov <bp@...e.de>
Cc: Alison Schofield <alison.schofield@...el.com>
Cc: "H. Peter Anvin" <hpa@...or.com>
Cc: Igor Mammedov <imammedo@...hat.com>
Cc: Ingo Molnar <mingo@...hat.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
Cc: Mike Rapoport <rppt@...ux.vnet.ibm.com>
Cc: Pu Wen <puwen@...on.cn>
Cc: Suravee Suthikulpanit <suravee.suthikulpanit@....com>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: x86-ml <x86@...nel.org>
Cc: Yazen Ghannam <yazen.ghannam@....com>
Cc: Zhenzhong Duan <zhenzhong.duan@...cle.com>
Link: https://lkml.kernel.org/r/1550495101-41755-1-git-send-email-zhangshaokun@hisilicon.com
---
 arch/x86/kernel/smpboot.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index ccd1f2a8e557..5d5421b48e55 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -149,7 +149,7 @@ static inline void smpboot_restore_warm_reset_vector(void)
  */
 static void smp_callin(void)
 {
-	int cpuid, phys_id;
+	int cpuid;
 
 	/*
 	 * If waken up by an INIT in an 82489DX configuration
@@ -159,11 +159,6 @@ static void smp_callin(void)
 	 */
 	cpuid = smp_processor_id();
 
-	/*
-	 * (This works even if the APIC is not enabled.)
-	 */
-	phys_id = read_apic_id();
-
 	/*
 	 * the boot CPU has finished the init stage and is spinning
 	 * on callin_map until we finish. We are free to set up this

Powered by blists - more mailing lists