linux-kernel - Re: [PATCH -next] ASoC: cs35l36: Make some symbols static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1902181126050.1596@james-tower>
Date:   Mon, 18 Feb 2019 17:26:47 +0000
From:   "Schulman, James" <James.Schulman@...rus.com>
To:     Wei Yongjun <weiyongjun1@...wei.com>
CC:     "Austin, Brian" <Brian.Austin@...rus.com>,
        "Handrigan, Paul" <Paul.Handrigan@...rus.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        "Schulman, James" <James.Schulman@...rus.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH -next] ASoC: cs35l36: Make some symbols static



On Mon, 18 Feb 2019, Wei Yongjun wrote:

> Fixes the following sparse warnings:
>
> sound/soc/codecs/cs35l36.c:135:20: warning:
> symbol 'cs35l36_reg' was not declared. Should it be static?
> sound/soc/codecs/cs35l36.c:248:6: warning:
> symbol 'cs35l36_readable_reg' was not declared. Should it be static?
> sound/soc/codecs/cs35l36.c:398:6: warning:
> symbol 'cs35l36_precious_reg' was not declared. Should it be static?
> sound/soc/codecs/cs35l36.c:410:6: warning:
> symbol 'cs35l36_volatile_reg' was not declared. Should it be static?
>
> Fixes: 6ba9dd6c893b ("ASoC: cs35l36: Add support for Cirrus CS35L36 Amplifier")
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
> sound/soc/codecs/cs35l36.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/codecs/cs35l36.c b/sound/soc/codecs/cs35l36.c
> index 4f880a678812..005f1adc80b8 100644
> --- a/sound/soc/codecs/cs35l36.c
> +++ b/sound/soc/codecs/cs35l36.c
> @@ -132,7 +132,7 @@ static const struct cs35l36_pll_config cs35l36_pll_sysclk[] = {
> 	{27000000,	0x3F, 0x0A},
> };
>
> -struct reg_default cs35l36_reg[] = {
> +static struct reg_default cs35l36_reg[] = {
> 	{CS35L36_TESTKEY_CTRL,			0x00000000},
> 	{CS35L36_USERKEY_CTL,			0x00000000},
> 	{CS35L36_OTP_CTRL1,			0x00002460},
> @@ -245,7 +245,7 @@ struct reg_default cs35l36_reg[] = {
> 	{CS35L36_PAC_INT7_CTRL,			0x00000001},
> };
>
> -bool cs35l36_readable_reg(struct device *dev, unsigned int reg)
> +static bool cs35l36_readable_reg(struct device *dev, unsigned int reg)
> {
> 	switch (reg) {
> 	case CS35L36_SW_RESET:
> @@ -395,7 +395,7 @@ bool cs35l36_readable_reg(struct device *dev, unsigned int reg)
> 	}
> }
>
> -bool cs35l36_precious_reg(struct device *dev, unsigned int reg)
> +static bool cs35l36_precious_reg(struct device *dev, unsigned int reg)
> {
> 	switch (reg) {
> 	case CS35L36_TESTKEY_CTRL:
> @@ -407,7 +407,7 @@ bool cs35l36_precious_reg(struct device *dev, unsigned int reg)
> 	}
> }
>
> -bool cs35l36_volatile_reg(struct device *dev, unsigned int reg)
> +static bool cs35l36_volatile_reg(struct device *dev, unsigned int reg)
> {
> 	switch (reg) {
> 	case CS35L36_SW_RESET:
>
>
>
>

Thanks Wei. I agree with the changes.

Acked-by: James Schulman <james.schulman@...rus.com>