lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 18 Feb 2019 11:50:53 -0600 From: "Gustavo A. R. Silva" <gustavo@...eddedor.com> To: Marcel Holtmann <marcel@...tmann.org> Cc: Johan Hedberg <johan.hedberg@...il.com>, "David S. Miller" <davem@...emloft.net>, linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH][next] Bluetooth: a2mp: Use struct_size() helper On 2/18/19 7:02 AM, Marcel Holtmann wrote: > Hi Gustavo, > >> One of the more common cases of allocation size calculations is finding >> the size of a structure that has a zero-sized array at the end, along >> with memory for some number of elements for that array. For example: >> >> struct foo { >> int stuff; >> struct boo entry[]; >> }; >> >> size = sizeof(struct foo) + count * sizeof(struct boo); >> instance = alloc(size, GFP_KERNEL) >> >> Instead of leaving these open-coded and prone to type mistakes, we can >> now use the new struct_size() helper: >> >> size = struct_size(instance, entry, count); >> instance = alloc(size, GFP_KERNEL) >> >> This code was detected with the help of Coccinelle. >> >> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com> >> --- >> net/bluetooth/a2mp.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > patch has been applied to bluetooth-next tree. > Thanks Marcel. -- Gustavo
Powered by blists - more mailing lists