linux-kernel - Re: [PATCH net v2] net: crypto set sk to NULL when af_alg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 18 Feb 2019 12:02:14 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     maowenan@...wei.com
Cc:     netdev@...r.kernel.org, xiyou.wangcong@...il.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2] net: crypto set sk to NULL when af_alg_release.

From: Mao Wenan <maowenan@...wei.com>
Date: Mon, 18 Feb 2019 10:44:44 +0800

> KASAN has found use-after-free in sockfs_setattr.
> The existed commit 6d8c50dcb029 ("socket: close race condition between sock_close()
> and sockfs_setattr()") is to fix this simillar issue, but it seems to ignore
> that crypto module forgets to set the sk to NULL after af_alg_release.
> 
> KASAN report details as below:
> BUG: KASAN: use-after-free in sockfs_setattr+0x120/0x150
> Write of size 4 at addr ffff88837b956128 by task syz-executor0/4186
 ...
> Fixes: 6d8c50dcb029 ("socket: close race condition between sock_close() and sockfs_setattr()")
> Signed-off-by: Mao Wenan <maowenan@...wei.com>

Applied and queued up for -stable, thanks.