linux-kernel - Re: [PATCH v2 2/2] gpio: sprd: Change to use SoC compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190218200737.GA7091@bogus>
Date:   Mon, 18 Feb 2019 14:07:38 -0600
From:   Rob Herring <robh@...nel.org>
To:     Baolin Wang <baolin.wang@...aro.org>
Cc:     mark.rutland@....com, linus.walleij@...aro.org,
        bgolaszewski@...libre.com, orsonzhai@...il.com,
        zhang.lyra@...il.com, broonie@...nel.org,
        devicetree@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] gpio: sprd: Change to use SoC compatible string

On Fri, Feb 15, 2019 at 12:55:19PM +0800, Baolin Wang wrote:
> Change to use SoC compatible string instead of wildcard string.
> 
> Signed-off-by: Baolin Wang <baolin.wang@...aro.org>
> ---
> Changes from v1:
>  - None.
> ---
>  drivers/gpio/gpio-pmic-eic-sprd.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpio-pmic-eic-sprd.c b/drivers/gpio/gpio-pmic-eic-sprd.c
> index ac573da..24228cf 100644
> --- a/drivers/gpio/gpio-pmic-eic-sprd.c
> +++ b/drivers/gpio/gpio-pmic-eic-sprd.c
> @@ -364,7 +364,7 @@ static int sprd_pmic_eic_probe(struct platform_device *pdev)
>  }
>  
>  static const struct of_device_id sprd_pmic_eic_of_match[] = {
> -	{ .compatible = "sprd,sc27xx-eic", },
> +	{ .compatible = "sprd,sc2731-eic", },

You need to keep the old one if you care about backwards compatibility. 
If you don't then state why in the commit message.

>  	{ /* end of list */ }
>  };
>  MODULE_DEVICE_TABLE(of, sprd_pmic_eic_of_match);
> -- 
> 1.7.9.5
>