lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 18 Feb 2019 23:04:46 +0100
From:   Enric Balletbo Serra <eballetbo@...il.com>
To:     Sebastian Reichel <sre@...nel.org>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Marcel Holtmann <marcel@...tmann.org>,
        Tony Lindgren <tony@...mide.com>,
        Rob Herring <robh@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Pavel Machek <pavel@....cz>, linux-bluetooth@...r.kernel.org,
        linux-media@...r.kernel.org, linux-omap@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Sebastian Reichel <sebastian.reichel@...labora.com>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>
Subject: Re: [PATCH 02/14] ARM: dts: IGEP: Add WiLink UART node

Hi Sebastian,

Sorry to take so long to reply

Missatge de Sebastian Reichel <sre@...nel.org> del dia dv., 21 de des.
2018 a les 9:05:
>
> From: Sebastian Reichel <sebastian.reichel@...labora.com>
>
> Add a node for the UART part of WiLink chip.
>
> Cc: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.com>
> ---
> This is compile tested only!
> ---
>  arch/arm/boot/dts/omap3-igep0020-rev-f.dts | 8 ++++++++
>  arch/arm/boot/dts/omap3-igep0030-rev-g.dts | 8 ++++++++
>  2 files changed, 16 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap3-igep0020-rev-f.dts b/arch/arm/boot/dts/omap3-igep0020-rev-f.dts
> index 285681d7af49..8bb4298ca05e 100644
> --- a/arch/arm/boot/dts/omap3-igep0020-rev-f.dts
> +++ b/arch/arm/boot/dts/omap3-igep0020-rev-f.dts
> @@ -52,3 +52,11 @@
>                 interrupts = <17 IRQ_TYPE_EDGE_RISING>; /* gpio 177 */
>         };
>  };
> +
> +&uart2 {
> +       bluetooth {
> +               compatible = "ti,wl1835-st";

That should be "ti,wl1831-st"

> +               enable-gpios = <&gpio5 9 GPIO_ACTIVE_HIGH>; /* gpio 137 */
> +               max-speed = <300000>;
> +       };
> +};
> diff --git a/arch/arm/boot/dts/omap3-igep0030-rev-g.dts b/arch/arm/boot/dts/omap3-igep0030-rev-g.dts
> index 1adc73bd2ca0..03be171e9de7 100644
> --- a/arch/arm/boot/dts/omap3-igep0030-rev-g.dts
> +++ b/arch/arm/boot/dts/omap3-igep0030-rev-g.dts
> @@ -74,3 +74,11 @@
>                 interrupts = <8 IRQ_TYPE_EDGE_RISING>; /* gpio 136 */
>         };
>  };
> +
> +&uart2 {
> +       bluetooth {
> +               compatible = "ti,wl1835-st";

That should be "ti,wl1831-st"

> +               enable-gpios = <&gpio5 9 GPIO_ACTIVE_HIGH>; /* gpio 137 */
> +               max-speed = <300000>;
> +       };
> +};
> --
> 2.19.2
>

Apart from that,

Acked-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>

Powered by blists - more mailing lists