linux-kernel - Re: [PATCH] ASoC: samsung: i2s: Prevent potential NULL platform data dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJKOXPdu7y-kn3KM_Bf0s47N30YczDgfg95SVRRzqGY9rxYdjw@mail.gmail.com>
Date:   Mon, 18 Feb 2019 09:24:55 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Sylwester Nawrocki <s.nawrocki@...sung.com>
Cc:     broonie@...nel.org, lgirdwood@...il.com, sbkim73@...sung.com,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: samsung: i2s: Prevent potential NULL platform data dereference

On Thu, 14 Feb 2019 at 16:58, Sylwester Nawrocki <s.nawrocki@...sung.com> wrote:
>
> When np is NULL i2s_pdata could also be NULL but i2s_pdata is now being
> dereferenced without proper check. Fix this and shorten the error message
> so we don't exceed 80 characters limit.
>
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@...sung.com>
> ---
>  sound/soc/samsung/i2s.c | 27 +++++++++++++++------------
>  1 file changed, 15 insertions(+), 12 deletions(-)

Reviewed-by: Krzysztof Kozlowski <krzk@...nel.org>

Best regards,
Krzysztof