[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <abb56481-0cc7-3d31-2dae-ba602a423811@nvidia.com>
Date: Mon, 18 Feb 2019 09:55:43 +0000
From: Jon Hunter <jonathanh@...dia.com>
To: Chanwoo Choi <cw00.choi@...sung.com>,
Yangtao Li <tiny.windzz@...il.com>, <myungjoo.ham@...sung.com>,
<kyungmin.park@...sung.com>, <heiko@...ech.de>,
<thierry.reding@...il.com>
CC: <linux-pm@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
<linux-rockchip@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>, <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH 3/3] PM / devfreq: tegra: remove unneeded variable
On 18/02/2019 00:38, Chanwoo Choi wrote:
> On 19. 2. 17. 오전 12:18, Yangtao Li wrote:
>> This variable is not used after initialization, so
>> remove it. And in order to unify the code style,
>> move the location where the dev_get_drvdata is called
>> by the way.
>>
>> Signed-off-by: Yangtao Li <tiny.windzz@...il.com>
>> ---
>> drivers/devfreq/tegra-devfreq.c | 7 ++-----
>> 1 file changed, 2 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c
>> index c59d2eee5d30..c89ba7b834ff 100644
>> --- a/drivers/devfreq/tegra-devfreq.c
>> +++ b/drivers/devfreq/tegra-devfreq.c
>> @@ -573,10 +573,7 @@ static int tegra_governor_get_target(struct devfreq *devfreq,
>> static int tegra_governor_event_handler(struct devfreq *devfreq,
>> unsigned int event, void *data)
>> {
>> - struct tegra_devfreq *tegra;
>> - int ret = 0;
>> -
>> - tegra = dev_get_drvdata(devfreq->dev.parent);
>> + struct tegra_devfreq *tegra = dev_get_drvdata(devfreq->dev.parent);
>>
>> switch (event) {
>> case DEVFREQ_GOV_START:
>> @@ -600,7 +597,7 @@ static int tegra_governor_event_handler(struct devfreq *devfreq,
>> break;
>> }
>>
>> - return ret;
>> + return 0;
>> }
>>
>> static struct devfreq_governor tegra_devfreq_governor = {
>>
>
> Reviewed-by: Chanwoo Choi <cw00.choi@...sung.com>
>
Acked-by: Jon Hunter <jonathanh@...dia.com>
Thanks!
Jon
--
nvpublic
Powered by blists - more mailing lists