linux-kernel - Re: [PATCH] i2c: Allow recovery of the initial IRQ by a i2c client device.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190218100652.GB27940@ediswmail.ad.cirrus.com>
Date:   Mon, 18 Feb 2019 10:06:52 +0000
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     Jim Broadus <jbroadus@...il.com>
CC:     <benjamin.tissoires@...hat.com>, <wsa@...-dreams.de>,
        <linux-i2c@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] i2c: Allow recovery of the initial IRQ by a i2c client
 device.

On Fri, Feb 15, 2019 at 04:15:33PM -0800, Jim Broadus wrote:
> A previous change allowed i2c client devices to discover new IRQs upon
> reprobe. By clearing the IRQ in i2c_device_remove. However, if an IRQ was
> assigned in i2c_new_device, that information is lost.
> 
> For example, the touchscreen and trackpad devices on a Dell Inspiron laptop
> are I2C devices whose IRQs are defined by ACPI extended IRQ types. The
> client device structures are initialized during an ACPI walk. After
> removing the i2c_hid device, modprobe fails.
> 
> This change caches the initial IRQ value in i2c_new_device and then resets
> the client device IRQ to the initial value in i2c_device_remove.
> 
> Fixes: 6f108dd70d30 ("i2c: Clear client->irq in i2c_device_remove")
> Signed-off-by: Jim Broadus <jbroadus@...il.com>
> ---

Reviewed-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Apologies for the issues caused. I think this looks like a good fix
to me.

Thanks,
Charles