linux-kernel - Re: [PATCH] i2c: cadence: try reset when master receive arbitration lost

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4731eba7-7d85-62b9-2252-24ad55d75a0c@xilinx.com>
Date:   Mon, 18 Feb 2019 11:11:53 +0100
From:   Michal Simek <michal.simek@...inx.com>
To:     Shikai Wang <sxauwsk@....com>,
        Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>
CC:     Michal Simek <michal.simek@...inx.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-i2c@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] i2c: cadence: try reset when master receive arbitration
 lost

On 18. 02. 19 10:41, Shikai Wang wrote:
> When the adapter receive arbitration lost error interrupts,
> cdns_i2c_master_xfer return to the caller directly instead of resetting
> the adapter which resulted in the adapter being out of control.
> 
> So when driver detect err_status such as arbitration lost,
> then try to repair and fix it.
> 
> Signed-off-by: Shikai Wang <sxauwsk@....com>

ok. This is much better.

> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>

I haven't see that Shubhrajyoti gave you this line that he is coauthor
of this.
It means you shouldn't add this SoB line if he didn't work on this.
He reviewed it that's why you should wait what he is going to sent.

Anyway based on email I see that this is 3rd version but I can't see any
version in subject and also description of changes.

That's why please take a look at this
Documentation/process/submitting-patches.rst

And send proper version. I would suggest to use v2 or v3.

Thanks,
Michal