lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 18 Feb 2019 11:40:12 +0100
From:   Geert Uytterhoeven <>
To:     Krzysztof Kozlowski <>
Cc:     Russell King <>,
        Mark Brown <>,
        Linux Kernel Mailing List <>,
        linux-spi <>,
        Greg Kroah-Hartman <>,
        "Rafael J. Wysocki" <>,
        Sylwester Nawrocki <>,
        Tomasz Figa <>,
        Chanwoo Choi <>,
        Michael Turquette <>,
        Stephen Boyd <>, Kukjin Kim <>,
        Andy Gross <>,
        David Brown <>,
        Srinivas Kandagatla <>,,
        linux-clk <>,
        Linux ARM <>,,
        ALSA Development Mailing List <>
Subject: Re: [RFC 0/4] clk/driver: platform: Fix kfree() of const memory on
 setting driver_override

Hi Krzysztof,

On Mon, Feb 18, 2019 at 11:27 AM Krzysztof Kozlowski <> wrote:
> The problem
> ===========
> Several device types (platform, amba, spi etc.) provide a driver_override
> field.  On sysfs store or during device removal, they kfree() the
> existing value.
> However the users are unaware of this and set the driver_override like:
>         pdev->driver_override = "exynos5-subcmu";
> which obviously leads to error.

IMHO driver_override is not meant to be set by a driver, only from userspace,
for binding the device to vfio (is there another use case?).

>   clk: samsung: exynos5: Fix kfree() of const memory on setting
>     driver_override
>   slimbus: ngd: Fix kfree() of const memory on setting driver_override

I see all users set override immediately after allocating a platform device.
Can't they just allocate a platform device using the override name instead?
What am I missing?




Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Powered by blists - more mailing lists