linux-kernel - Re: [PATCH] Bluetooth: remove redundant zero check on count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <050CD529-5C31-4761-BCC8-04630D0038DE@holtmann.org>
Date:   Mon, 18 Feb 2019 11:48:18 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        linux-bluetooth@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Bluetooth: remove redundant zero check on count

Hi Colin,

> Variable count is never zero inside the loop so the check if count is
> zero is redundant and can be removed. Fix this.
> 
> Detected by CoverityScan, CID#1466880 ("Logically dead code")
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
> drivers/bluetooth/h4_recv.h | 3 ---
> 1 file changed, 3 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel