lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 18 Feb 2019 10:59:15 +0000
From:   <Nicolas.Ferre@...rochip.com>
To:     <Claudiu.Beznea@...rochip.com>, <robh+dt@...nel.org>,
        <mark.rutland@....com>, <alexandre.belloni@...tlin.com>,
        <Ludovic.Desroches@...rochip.com>, <sre@...nel.org>
CC:     <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linux-pm@...r.kernel.org>
Subject: Re: [PATCH 1/3] power: reset: at91-poweroff: add RTT wakeup
 capability

On 14/02/2019 at 12:24, Claudiu Beznea - M18063 wrote:
> From: Claudiu Beznea <claudiu.beznea@...rochip.com>
> 
> Add RTT wakeup capability.
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@...rochip.com>

Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

> ---
>   drivers/power/reset/at91-sama5d2_shdwc.c | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
> 
> diff --git a/drivers/power/reset/at91-sama5d2_shdwc.c b/drivers/power/reset/at91-sama5d2_shdwc.c
> index 2b686c55b717..0747e0cdf350 100644
> --- a/drivers/power/reset/at91-sama5d2_shdwc.c
> +++ b/drivers/power/reset/at91-sama5d2_shdwc.c
> @@ -57,15 +57,21 @@
>   
>   #define SHDW_WK_PIN(reg, cfg)	((reg) & AT91_SHDW_WKUPIS((cfg)->wkup_pin_input))
>   #define SHDW_RTCWK(reg, cfg)	(((reg) >> ((cfg)->sr_rtcwk_shift)) & 0x1)
> +#define SHDW_RTTWK(reg, cfg)	(((reg) >> ((cfg)->sr_rttwk_shift)) & 0x1)
>   #define SHDW_RTCWKEN(cfg)	(1 << ((cfg)->mr_rtcwk_shift))
> +#define SHDW_RTTWKEN(cfg)	(1 << ((cfg)->mr_rttwk_shift))
>   
>   #define DBC_PERIOD_US(x)	DIV_ROUND_UP_ULL((1000000 * (x)), \
>   							SLOW_CLOCK_FREQ)
>   
> +#define SHDW_CFG_NOT_USED	(32)
> +
>   struct shdwc_config {
>   	u8 wkup_pin_input;
>   	u8 mr_rtcwk_shift;
> +	u8 mr_rttwk_shift;
>   	u8 sr_rtcwk_shift;
> +	u8 sr_rttwk_shift;
>   };
>   
>   struct shdwc {
> @@ -104,6 +110,8 @@ static void __init at91_wakeup_status(struct platform_device *pdev)
>   		reason = "WKUP pin";
>   	else if (SHDW_RTCWK(reg, shdw->cfg))
>   		reason = "RTC";
> +	else if (SHDW_RTTWK(reg, shdw->cfg))
> +		reason = "RTT";
>   
>   	pr_info("AT91: Wake-Up source: %s\n", reason);
>   }
> @@ -221,6 +229,9 @@ static void at91_shdwc_dt_configure(struct platform_device *pdev)
>   	if (of_property_read_bool(np, "atmel,wakeup-rtc-timer"))
>   		mode |= SHDW_RTCWKEN(shdw->cfg);
>   
> +	if (of_property_read_bool(np, "atmel,wakeup-rtt-timer"))
> +		mode |= SHDW_RTTWKEN(shdw->cfg);
> +
>   	dev_dbg(&pdev->dev, "%s: mode = %#x\n", __func__, mode);
>   	writel(mode, shdw->shdwc_base + AT91_SHDW_MR);
>   
> @@ -231,7 +242,10 @@ static void at91_shdwc_dt_configure(struct platform_device *pdev)
>   static const struct shdwc_config sama5d2_shdwc_config = {
>   	.wkup_pin_input = 0,
>   	.mr_rtcwk_shift = 17,
> +	.mr_rttwk_shift	= SHDW_CFG_NOT_USED,
>   	.sr_rtcwk_shift = 5,
> +	.sr_rttwk_shift = SHDW_CFG_NOT_USED,
> +};
>   };
>   
>   static const struct of_device_id at91_shdwc_of_match[] = {
> 


-- 
Nicolas Ferre

Powered by blists - more mailing lists