lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 18 Feb 2019 11:26:57 +0000 From: Brian Starkey <Brian.Starkey@....com> To: John Stultz <john.stultz@...aro.org> CC: "Andrew F. Davis" <afd@...com>, Laura Abbott <labbott@...hat.com>, Sumit Semwal <sumit.semwal@...aro.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Arve Hjønnevåg <arve@...roid.com>, Christoph Hellwig <hch@...radead.org>, Liam Mark <lmark@...eaurora.org>, "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>, lkml <linux-kernel@...r.kernel.org>, dri-devel <dri-devel@...ts.freedesktop.org>, nd <nd@....com> Subject: Re: [PATCH v2] staging: android: ion: Allocate from heap ID directly without mask On Fri, Feb 15, 2019 at 11:01:59AM -0800, John Stultz wrote: > On Fri, Feb 15, 2019 at 2:51 AM Brian Starkey <Brian.Starkey@....com> wrote: > > > > Hi John, > > > > On Thu, Feb 14, 2019 at 09:38:29AM -0800, John Stultz wrote: > > > > > [snip] > > > > > Some thoughts, as this ABI break has the potential to be pretty painful. > > > > > > 1) Unfortunately, this ABI is exposed *through* libion via > > > ion_alloc/ion_alloc_fd out to gralloc implementations. Which means it > > > will have a wider impact to vendor userland code. > > > > I figured libion could fairly easily loop through all the set bits in > > heap_mask and call the ioctl for each until it succeeds. That > > preserves the old behaviour from the libion clients' perspective. > > Potentially, though that implicitly still caps the heaps to 32. So > I'm not sure what the net benefit would be. > It's purely a transitionary compatibility measure. Users of the old API inherit the old limitation - they shouldn't care about that. Alongside it, we'd want to add new function(s) exposing whatever the new API is. Cheers, -Brian
Powered by blists - more mailing lists