lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 18 Feb 2019 14:21:34 +0200 From: Andy Shevchenko <andy.shevchenko@...il.com> To: Yu Chen <chenyu56@...wei.com> Cc: USB <linux-usb@...r.kernel.org>, devicetree <devicetree@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, John Stultz <john.stultz@...aro.org>, Suzhuangluan <suzhuangluan@...ilicon.com>, Kongfei <kongfei@...ilicon.com>, liuyu712@...ilicon.com, wanghu17@...ilicon.com, butao@...ilicon.com, Yao Chen <chenyao11@...wei.com>, fangshengzhou@...ilicon.com, lipengcheng8@...wei.com, songxiaowei <songxiaowei@...ilicon.com>, xu yiping <xuyiping@...ilicon.com>, xuyoujun4@...wei.com, yudongbin@...ilicon.com, zangleigang@...ilicon.com, Felipe Balbi <balbi@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Binghui Wang <wangbinghui@...ilicon.com> Subject: Re: [PATCH v2 04/10] usb: dwc3: Add two quirks for Hisilicon Kirin Soc Platform On Mon, Feb 18, 2019 at 1:23 PM Yu Chen <chenyu56@...wei.com> wrote: > > There are tow quirks for DesignWare USB3 DRD Core of Hisilicon Kirin Soc. > 1)SPLIT_BOUNDARY_DISABLE should be set for Host mode > 2)A GCTL soft reset should be executed when switch mode Thus, it must be two patches, no? > +static void dwc3_gctl_core_soft_reset(struct dwc3 *dwc) > +{ > + u32 reg; > + > + reg = dwc3_readl(dwc->regs, DWC3_GCTL); > + reg |= (DWC3_GCTL_CORESOFTRESET); Redundant parens. > + dwc3_writel(dwc->regs, DWC3_GCTL, reg); > + > + reg = dwc3_readl(dwc->regs, DWC3_GCTL); > + reg &= ~(DWC3_GCTL_CORESOFTRESET); Ditto. > + dwc3_writel(dwc->regs, DWC3_GCTL, reg); > +} > +static void dwc3_complete(struct device *dev) > +{ > + struct dwc3 *dwc = dev_get_drvdata(dev); > + u32 reg; Indentation style is different to the other functions in the same patch. Use simple space here. > + if (dwc->current_dr_role == DWC3_GCTL_PRTCAP_HOST && > + dwc->dis_split_quirk) { > + dev_dbg(dwc->dev, "set DWC3_GUCTL3_SPLITDISABLE\n"); > + reg = dwc3_readl(dwc->regs, DWC3_GUCTL3); > + reg |= DWC3_GUCTL3_SPLITDISABLE; > + dwc3_writel(dwc->regs, DWC3_GUCTL3, reg); > + } > +} > --- a/drivers/usb/dwc3/gadget.c > +++ b/drivers/usb/dwc3/gadget.c > @@ -269,7 +269,7 @@ int dwc3_send_gadget_ep_cmd(struct dwc3_ep *dep, unsigned cmd, > { > const struct usb_endpoint_descriptor *desc = dep->endpoint.desc; > struct dwc3 *dwc = dep->dwc; > - u32 timeout = 1000; > + u32 timeout = 5000; I don't see anything about this change in commit message. Moreoever, it looks like it must be a separate logical change with its own description. > u32 saved_config = 0; > u32 reg; -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists