linux-kernel - Re: [PATCH -next] powerpc/pseries: Fix platform_no_drv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <88ec8c6a-68ac-a96c-0a82-b2537fc699f2@huawei.com>
Date:   Mon, 18 Feb 2019 21:21:11 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     Julia Lawall <julia.lawall@...6.fr>
CC:     Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Oliver O'Halloran <oohall@...il.com>,
        Dan Williams <dan.j.williams@...el.com>,
        <linuxppc-dev@...ts.ozlabs.org>, <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH -next] powerpc/pseries: Fix platform_no_drv_owner.cocci
 warnings

On 2019/2/18 20:53, Julia Lawall wrote:
> 
> 
> On Mon, 18 Feb 2019, YueHaibing wrote:
> 
>> Remove .owner field if calls are used which set it automatically
>> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>>
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>> ---
>>  arch/powerpc/platforms/pseries/papr_scm.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c
>> index bba281b1fe1b..e3f5c1a01950 100644
>> --- a/arch/powerpc/platforms/pseries/papr_scm.c
>> +++ b/arch/powerpc/platforms/pseries/papr_scm.c
>> @@ -21,6 +21,7 @@
>>  	 (1ul << ND_CMD_GET_CONFIG_DATA) | \
>>  	 (1ul << ND_CMD_SET_CONFIG_DATA))
>>
>> +
> 
> No need to add a blank line.

Yes, will fix it.

> 
> julia
> 
>>  struct papr_scm_priv {
>>  	struct platform_device *pdev;
>>  	struct device_node *dn;
>> @@ -358,7 +359,6 @@ static struct platform_driver papr_scm_driver = {
>>  	.remove = papr_scm_remove,
>>  	.driver = {
>>  		.name = "papr_scm",
>> -		.owner = THIS_MODULE,
>>  		.of_match_table = papr_scm_match,
>>  	},
>>  };
>>
>>
>>
>>
> 
> .
>