lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 18 Feb 2019 14:43:53 +0100
From:   Greg Kroah-Hartman <>
Cc:     Greg Kroah-Hartman <>,, Paul Burton <>,, Kevin Hilman <>,
        Guenter Roeck <>,
        "Maciej W . Rozycki" <>
Subject: [PATCH 4.4 105/143] MIPS: VDSO: Include $(ccflags-vdso) in o32,n32 .lds builds

4.4-stable review patch.  If anyone has any objections, please let me know.


From: Paul Burton <>

commit 67fc5dc8a541e8f458d7f08bf88ff55933bf9f9d upstream.

When generating & for use with programs
running as compat ABIs under 64b kernels, we previously haven't included
the compiler flags that are supposedly common to all ABIs - ie. those in
the ccflags-vdso variable.

This is problematic in cases where we need to provide the -m%-float flag
in order to ensure that we don't attempt to use a floating point ABI
that's incompatible with the target CPU & ABI. For example a toolchain
using current gcc trunk configured --with-fp-32=xx fails to build a
64r6el_defconfig kernel with the following error:

  cc1: error: '-march=mips1' requires '-mfp32'
  make[2]: *** [arch/mips/vdso/Makefile:135: arch/mips/vdso/] Error 1

Include $(ccflags-vdso) for the compat VDSO .lds builds, just as it is
included for the native VDSO .lds & when compiling objects for the
compat VDSOs. This ensures we consistently provide the -msoft-float flag
amongst others, avoiding the problem by ensuring we're agnostic to the
toolchain defaults.

Signed-off-by: Paul Burton <>
Fixes: ebb5e78cc634 ("MIPS: Initial implementation of a VDSO")
Cc: Kevin Hilman <>
Cc: Guenter Roeck <>
Cc: Maciej W . Rozycki <>
Cc: # v4.4+
Signed-off-by: Greg Kroah-Hartman <>

 arch/mips/vdso/Makefile |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/arch/mips/vdso/Makefile
+++ b/arch/mips/vdso/Makefile
@@ -107,7 +107,7 @@ $(obj)/%-o32.o: $(src)/%.c FORCE
 	$(call cmd,force_checksrc)
 	$(call if_changed_rule,cc_o_c)
-$(obj)/ KBUILD_CPPFLAGS := -mabi=32
+$(obj)/ KBUILD_CPPFLAGS := $(ccflags-vdso) -mabi=32
 $(obj)/ $(src)/ FORCE
 	$(call if_changed_dep,cpp_lds_S)
@@ -143,7 +143,7 @@ $(obj)/%-n32.o: $(src)/%.c FORCE
 	$(call cmd,force_checksrc)
 	$(call if_changed_rule,cc_o_c)
-$(obj)/ KBUILD_CPPFLAGS := -mabi=n32
+$(obj)/ KBUILD_CPPFLAGS := $(ccflags-vdso) -mabi=n32
 $(obj)/ $(src)/ FORCE
 	$(call if_changed_dep,cpp_lds_S)

Powered by blists - more mailing lists