lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 18 Feb 2019 14:43:17 +0100 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: linux-kernel@...r.kernel.org Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, stable@...r.kernel.org, Markos Chandras <markos.chandras@...tec.com>, Paul Burton <paul.burton@...s.com>, linux-mips@...r.kernel.org, Jakub Kicinski <jakub.kicinski@...ronome.com>, Song Liu <songliubraving@...com>, Jiong Wang <jiong.wang@...ronome.com>, Alexei Starovoitov <ast@...nel.org>, Sasha Levin <sashal@...nel.org> Subject: [PATCH 3.18 021/108] mips: bpf: fix encoding bug for mm_srlv32_op 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 17f6c83fb5ebf7db4fcc94a5be4c22d5a7bfe428 ] For micro-mips, srlv inside POOL32A encoding space should use 0x50 sub-opcode, NOT 0x90. Some early version ISA doc describes the encoding as 0x90 for both srlv and srav, this looks to me was a typo. I checked Binutils libopcode implementation which is using 0x50 for srlv and 0x90 for srav. v1->v2: - Keep mm_srlv32_op sorted by value. Fixes: f31318fdf324 ("MIPS: uasm: Add srlv uasm instruction") Cc: Markos Chandras <markos.chandras@...tec.com> Cc: Paul Burton <paul.burton@...s.com> Cc: linux-mips@...r.kernel.org Acked-by: Jakub Kicinski <jakub.kicinski@...ronome.com> Acked-by: Song Liu <songliubraving@...com> Signed-off-by: Jiong Wang <jiong.wang@...ronome.com> Signed-off-by: Alexei Starovoitov <ast@...nel.org> Signed-off-by: Sasha Levin <sashal@...nel.org> --- arch/mips/include/uapi/asm/inst.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/mips/include/uapi/asm/inst.h b/arch/mips/include/uapi/asm/inst.h index 4bfdb9d4c186..3eb4d6177266 100644 --- a/arch/mips/include/uapi/asm/inst.h +++ b/arch/mips/include/uapi/asm/inst.h @@ -262,8 +262,8 @@ enum mm_32a_minor_op { mm_ext_op = 0x02c, mm_pool32axf_op = 0x03c, mm_srl32_op = 0x040, + mm_srlv32_op = 0x050, mm_sra_op = 0x080, - mm_srlv32_op = 0x090, mm_rotr_op = 0x0c0, mm_lwxs_op = 0x118, mm_addu32_op = 0x150, -- 2.19.1
Powered by blists - more mailing lists