linux-kernel - Re: [PATCH v2 01/10] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ee91d42-ab9d-1bd2-d39e-8af4d69a5c19@huawei.com>
Date:   Tue, 19 Feb 2019 11:55:31 +0800
From:   Chen Yu <chenyu56@...wei.com>
To:     Chunfeng Yun <chunfeng.yun@...iatek.com>
CC:     <liuyu712@...ilicon.com>, Rob Herring <robh@...nel.org>,
        <linux-usb@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <john.stultz@...aro.org>,
        <suzhuangluan@...ilicon.com>, <kongfei@...ilicon.com>,
        <wanghu17@...ilicon.com>, <butao@...ilicon.com>,
        <chenyao11@...wei.com>, <fangshengzhou@...ilicon.com>,
        <lipengcheng8@...wei.com>, <songxiaowei@...ilicon.com>,
        <xuyiping@...ilicon.com>, <xuyoujun4@...wei.com>,
        <yudongbin@...ilicon.com>, <zangleigang@...ilicon.com>,
        Mark Rutland <mark.rutland@....com>,
        "Binghui Wang" <wangbinghui@...ilicon.com>
Subject: Re: [PATCH v2 01/10] dt-bindings: phy: Add support for HiSilicon's
 hi3660 USB PHY

Hi,

On 2019/2/19 11:03, Chunfeng Yun wrote:
>>>> +
>>>> +Example:
>>>> +	usb-phy {
>>>> +		compatible = "hisilicon,hi3660-usb-phy";
>>>> +		#phy-cells = <0>;
>>>> +		hisilicon,pericrg-syscon = <&crg_ctrl>;
>>>> +		hisilicon,pctrl-syscon = <&pctrl>;
>>>> +		hisilicon,usb3-otg-bc-syscon = <&usb3_otg_bc>;
>>>
>>> Are most of the registers within one of these blocks? If so, make this 
>>> node a child of that node.
>> I met a problem when I made this node a child of the syscon node,
>> the driver "phy-hi3660-usb3" was not probed.
>> Do you have any idea about how to make it probed when it is a child node?
> call of_platform_populate() in parent node's driver,
> but I don't know whether it's a standard way
Yes, this function is used in dwc3 driver to probe the child node.
But I think it is not a good way to modify the syscon driver.
>>>
>>>> +		hisilicon,eye-diagram-param = <0x22466e4>;
>>>> +	};
>>>> -- 
>>>> 2.15.0-rc2
>>>>

Thanks
Yu Chen