linux-kernel - Re: [PATCH v2 13/15] ARM: dts: milbeaut: Add device tree set for the Milbeaut M10V board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ba5bb646-7fa6-e98f-4ac2-47c55c8f82ba@socionext.com>
Date:   Tue, 19 Feb 2019 14:11:21 +0900
From:   "Sugaya, Taichi" <sugaya.taichi@...ionext.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     DTML <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Takao Orito <orito.takao@...ionext.com>,
        Kazuhiro Kasai <kasai.kazuhiro@...ionext.com>,
        Shinji Kanematsu <kanematsu.shinji@...ionext.com>,
        Jassi Brar <jaswinder.singh@...aro.org>,
        Masami Hiramatsu <masami.hiramatsu@...aro.org>
Subject: Re: [PATCH v2 13/15] ARM: dts: milbeaut: Add device tree set for the
 Milbeaut M10V board

Hi,
Thank you for you comments.

On 2019/02/18 21:09, Arnd Bergmann wrote:
> On Fri, Feb 8, 2019 at 1:28 PM Sugaya Taichi
> <sugaya.taichi@...ionext.com> wrote:
>> +
>> +       aliases {
>> +               serial1 = &uart1;
>> +       };
> 
> Maybe start with serial0 here? It seems unusual to start
> counting at 1.
> 

The M10V evaluation board(EVB) uses a console with uart ch1, so this 
alias number is derived from the used channel one.
Therefore it is no problem to change the alias number to 0.

>> +       chosen {
>> +               bootargs = "init=/sbin/finit rootwait earlycon";
> 
> The /sbin/finit argument seems user space specific, so you probably don't
> want this in the dts file but rather pass it from the boot loader.
> Possible drop the bootargs entirely.
> 

Okay, remove the arg from the dts and add to bootargs instead.

Thanks,
Sugaya Taichi

>       Arnd
>