linux-kernel - Re: [PATCH v2 1/2] Provide in-kernel headers for making it easy to extend the kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190219060531.GA3263@avx2>
Date:   Tue, 19 Feb 2019 09:05:31 +0300
From:   Alexey Dobriyan <adobriyan@...il.com>
To:     joel@...lfernandes.org
Cc:     linux-kernel@...r.kernel.org, alexei.starovoitov@...il.com
Subject: Re: [PATCH v2 1/2] Provide in-kernel headers for making it easy to
 extend the kernel

> /proc/kheaders.txz

This is gross.

> The feature is also buildable as a module just in case the user desires
> it not being part of the kernel image. This makes it possible to load
> and unload the headers on demand. A tracing program, or a kernel module
> builder can load the module, do its operations, and then unload the
> module to save kernel memory.

Please explain how keeping headers on the filesystem is not OK due
to "licensing and other issues" but keeping a module on the filesystem
is OK.

> > I can route it via bpf-next tree if there are no objections.

Please don't.

IKHD_ST IKHD_ED are bogus artifacts as others mentioned.
proc_create(S_IFREG) is redundant.
seq_file.h is not needed as is THIS_MODULE.
I'd say such data should live in their own section for easy extraction
with "objdump -j", something /proc/config.gz never did.