lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 Feb 2019 16:12:11 +0900 From: "Sugaya, Taichi" <sugaya.taichi@...ionext.com> To: Arnd Bergmann <arnd@...db.de> Cc: Linux ARM <linux-arm-kernel@...ts.infradead.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Shinji Kanematsu <kanematsu.shinji@...ionext.com>, Masami Hiramatsu <masami.hiramatsu@...aro.org>, Russell King <linux@...linux.org.uk>, Jassi Brar <jaswinder.singh@...aro.org>, Takao Orito <orito.takao@...ionext.com>, Kazuhiro Kasai <kasai.kazuhiro@...ionext.com> Subject: Re: [PATCH v2 04/15] ARM: milbeaut: Add basic support for Milbeaut m10v SoC Hi, Thank you for your comments. On 2019/02/18 21:15, Arnd Bergmann wrote: > On Fri, Feb 8, 2019 at 1:26 PM Sugaya Taichi > <sugaya.taichi@...ionext.com> wrote: > >> +static int m10v_pm_enter(suspend_state_t state) >> +{ >> + switch (state) { >> + case PM_SUSPEND_STANDBY: >> + pr_err("STANDBY\n"); >> + asm("wfi"); >> + break; >> + case PM_SUSPEND_MEM: >> + pr_err("SUSPEND\n"); >> + cpu_pm_enter(); >> + cpu_suspend(0, m10v_die); >> + cpu_pm_exit(); >> + break; >> + } >> + return 0; >> +} > > It looks like you left the pr_err() messages from bringup, they should probably > be removed now. > OK. remove the pr_err()s. >> +static int __init m10v_pm_init(void) >> +{ >> + suspend_set_ops(&m10v_pm_ops); >> + >> + return 0; >> +} >> +late_initcall(m10v_pm_init); > > This requires a check to ensure you are actually on the right platform, > otherwise you break suspend/resume in a multiplatform kernel running > on anything other than milbeaut. > OK. I think the solution is adding a "if statement with mlbeaut compatible" above suspend_set_ops(&m10v_pm_ops). Thanks, Sugaya Taichi > Arnd >
Powered by blists - more mailing lists