linux-kernel - Re: [PATCH net] net: stmmac: Fix a race in EEE enable callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190218.174007.481602281794068390.davem@davemloft.net>
Date:   Mon, 18 Feb 2019 17:40:07 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     jose.abreu@...opsys.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        joao.pinto@...opsys.com, peppe.cavallaro@...com,
        alexandre.torgue@...com
Subject: Re: [PATCH net] net: stmmac: Fix a race in EEE enable callback

From: Jose Abreu <jose.abreu@...opsys.com>
Date: Mon, 18 Feb 2019 14:35:03 +0100

> We are saving the status of EEE even before we try to enable it. This
> leads to a race with XMIT function that tries to arm EEE timer before we
> set it up.
> 
> Fix this by only saving the EEE parameters after all operations are
> performed with success.
> 
> Signed-off-by: Jose Abreu <joabreu@...opsys.com>
> Fixes: d765955d2ae0 ("stmmac: add the Energy Efficient Ethernet support")

Applied and queued up for -stable, thanks.