linux-kernel - Re: [PATCH v2] PCI: Fix "try" semantics of bus and slot reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <70f40fdb-5a11-4688-c38b-b9372fdc58f5@kernel.org>
Date:   Mon, 18 Feb 2019 19:08:15 -0500
From:   Sinan Kaya <Okaya@...nel.org>
To:     Alex Williamson <alex.williamson@...hat.com>,
        linux-pci@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, bhelgaas@...gle.com, hch@....de,
        myron.stowe@...hat.com
Subject: Re: [PATCH v2] PCI: Fix "try" semantics of bus and slot reset

On 2/18/2019 2:46 PM, Alex Williamson wrote:
> The commit referenced below introduced device locking around save and
> restore of state for each device during a PCI bus "try" reset, making
> it decidely non-"try" and prone to deadlock in the event that a device
> is already locked.  Restore __pci_reset_bus() and __pci_reset_slot()
> to their advertised locking semantics by pushing the save and restore
> functions into the branch where the entire tree is already locked.
> Extend the helper function names with "_locked" and update the comment
> to reflect this calling requirement.
> 
> Fixes: b014e96d1abb ("PCI: Protect pci_error_handlers->reset_notify() usage with device_lock()")
> Signed-off-by: Alex Williamson <alex.williamson@...hat.com>
> ---

Reviewed-by: Sinan Kaya <okaya@...nel.org>