linux-kernel - RE: [PATCH 2/2] regulator: da9063: Select maximum current in specific range for set_current

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Feb 2019 13:57:53 +0000
From:   Steve Twiss <stwiss.opensource@...semi.com>
To:     Axel Lin <axel.lin@...ics.com>, Mark Brown <broonie@...nel.org>
CC:     Steve Twiss <stwiss.opensource@...semi.com>,
        Krystian Garbaciak <krystian.garbaciak@...semi.com>,
        Support Opensource <Support.Opensource@...semi.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/2] regulator: da9063: Select maximum current in specific
 range for set_current_limit

On 19 February 2019 13:31, Axel Lin wrote:

> To: Mark Brown <broonie@...nel.org>
> Subject: [PATCH 2/2] regulator: da9063: Select maximum current in specific range for set_current_limit
> 
> Selecting the minimal value is only true for voltage regulators.
> For current regulators the maximum in the given range should be
> selected instead.
> 
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
>  drivers/regulator/da9063-regulator.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-
> regulator.c
> index 85c45577bad1..a83bbd3dbc37 100644
> --- a/drivers/regulator/da9063-regulator.c
> +++ b/drivers/regulator/da9063-regulator.c
> @@ -167,7 +167,7 @@ static int da9063_set_current_limit(struct regulator_dev
> *rdev,
>  	const struct da9063_regulator_info *rinfo = regl->info;
>  	int n, tval;
> 
> -	for (n = 0; n < rinfo->n_current_limits; n++) {
> +	for (n = rinfo->n_current_limits - 1; n >= 0; n--) {
>  		tval = rinfo->current_limits[n];
>  		if (tval >= min_uA && tval <= max_uA)
>  			return regmap_field_write(regl->ilimit, n);

Acked-by: Steve Twiss <stwiss.opensource@...semi.com>