linux-kernel - Re: [PATCH][next] usb: typec: mux: remove redundant check on variable match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190219144538.GA27637@kuha.fi.intel.com>
Date:   Tue, 19 Feb 2019 16:45:38 +0200
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] usb: typec: mux: remove redundant check on
 variable match

On Tue, Feb 19, 2019 at 01:43:33PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> All the code paths that lead to the return statement are where
> match is always true, hence the check to see if it is true is
> redundant and can be removed.
> 
> Detected by CoverityScan, CID#14769672 ("Logically dead code")
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Acked-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
>  drivers/usb/typec/mux.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/mux.c b/drivers/usb/typec/mux.c
> index a5947d98824d..b94e2920eb38 100644
> --- a/drivers/usb/typec/mux.c
> +++ b/drivers/usb/typec/mux.c
> @@ -184,7 +184,7 @@ static void *typec_mux_match(struct device_connection *con, int ep, void *data)
>  		if (dev_fwnode(mux->dev) == con->fwnode)
>  			return mux;
>  
> -	return match ? ERR_PTR(-EPROBE_DEFER) : NULL;
> +	return ERR_PTR(-EPROBE_DEFER);
>  }
>  
>  /**
> -- 
> 2.20.1

thanks,

-- 
heikki