linux-kernel - Re: [PATCH 1/2] ASoC: codecs: pcm186x: fix wrong usage of DECLARE_TLV_DB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4de1b52b-70dc-7767-ba16-2d785d36a4c2@microchip.com>
Date:   Tue, 19 Feb 2019 16:20:41 +0000
From:   <Codrin.Ciubotariu@...rochip.com>
To:     <lgirdwood@...il.com>, <broonie@...nel.org>
CC:     <dannenberg@...com>, <m-stecklein@...com>, <afd@...com>,
        <alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] ASoC: codecs: pcm186x: fix wrong usage of
 DECLARE_TLV_DB_LINEAR()

On 19.02.2019 18:15, Codrin Ciubotariu - M19940 wrote:
> From: Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>
> 
> According to DS, the gain is between -12 dB and 40 dB, with a 0.5 dB step.
> Tested on pcm1863.
> 
> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>
> ---
>   sound/soc/codecs/pcm186x.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/pcm186x.c b/sound/soc/codecs/pcm186x.c
> index 809b7e9f03ca..7947279243f9 100644
> --- a/sound/soc/codecs/pcm186x.c
> +++ b/sound/soc/codecs/pcm186x.c
> @@ -6,7 +6,6 @@
>    *	Andreas Dannenberg <dannenberg@...com>
>    *	Andrew F. Davis <afd@...com>
>    */
> -
>   #include <linux/module.h>
>   #include <linux/moduleparam.h>
>   #include <linux/init.h>
> @@ -42,7 +41,7 @@ struct pcm186x_priv {
>   	bool is_master_mode;
>   };
>   
> -static const DECLARE_TLV_DB_SCALE(pcm186x_pga_tlv, -1200, 4000, 50);
> +static const DECLARE_TLV_DB_SCALE(pcm186x_pga_tlv, -1200, 50, 0);
>   
>   static const struct snd_kcontrol_new pcm1863_snd_controls[] = {
>   	SOC_DOUBLE_R_S_TLV("ADC Capture Volume", PCM186X_PGA_VAL_CH1_L,
> 

the title is wrong, there is no DECLARE_TLV_DB_LINEAR()present. Will 
send v2.

Best regards,
Codrin