linux-kernel - Re: [PATCH] platform/x86: dell-laptop: Mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 19 Feb 2019 10:33:53 -0600
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Darren Hart <dvhart@...radead.org>
Cc:     Matthew Garrett <mjg59@...f.ucam.org>,
        Pali Rohár <pali.rohar@...il.com>,
        Andy Shevchenko <andy@...radead.org>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: dell-laptop: Mark expected switch
 fall-throughs



On 11/28/18 6:15 PM, Darren Hart wrote:
> On Thu, Jul 05, 2018 at 03:38:07PM -0500, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> 
> I've applied this patch, but not the acer or sony fall through patches
> due to the pending questions there. Happy to revisit those as needed,
> but closing these out of the patch queue.
> 

Thanks, Darren.

I'll send separate patches for those that are still pending.  Hopefully,
I'll get some feedback this time.

--
Gustavo

>> ---
>>  drivers/platform/x86/dell-laptop.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
>> index f1fa861..1938f11 100644
>> --- a/drivers/platform/x86/dell-laptop.c
>> +++ b/drivers/platform/x86/dell-laptop.c
>> @@ -1565,8 +1565,10 @@ static ssize_t kbd_led_timeout_store(struct device *dev,
>>  		switch (unit) {
>>  		case KBD_TIMEOUT_DAYS:
>>  			value *= 24;
>> +			/* fall through */
>>  		case KBD_TIMEOUT_HOURS:
>>  			value *= 60;
>> +			/* fall through */
>>  		case KBD_TIMEOUT_MINUTES:
>>  			value *= 60;
>>  			unit = KBD_TIMEOUT_SECONDS;
>> -- 
>> 2.7.4
>>
>>
>