linux-kernel - Re: [PATCH] hwrng: bcm2835 - fix probe as platform device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <da2960dd-5b52-d972-f7fa-09e9dd5bc30c@gmail.com>
Date:   Tue, 19 Feb 2019 10:52:09 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Jonas Gorski <jonas.gorski@...il.com>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Matt Mackall <mpm@...enic.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com,
        Eric Anholt <eric@...olt.net>,
        Stefan Wahren <stefan.wahren@...e.com>
Subject: Re: [PATCH] hwrng: bcm2835 - fix probe as platform device

On 2/19/19 4:16 AM, Jonas Gorski wrote:
> BCM63XX (MIPS) does not use device tree, so there cannot be any
> of_device_id, causing the driver to fail on probe:
> 
> [    0.904564] bcm2835-rng: probe of bcm63xx-rng failed with error -22
> 
> Fix this by checking for match data only if we are probing from device
> tree.
> 
> Fixes: 8705f24f7b57 ("hwrng: bcm2835 - Enable BCM2835 RNG to work on BCM63xx platforms")
> Signed-off-by: Jonas Gorski <jonas.gorski@...il.com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>

Sorry about that, thanks for the fix!
-- 
Florian