lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 Feb 2019 19:27:27 +0000 From: "Brown, Len" <len.brown@...el.com> To: "Liang, Kan" <kan.liang@...ux.intel.com>, Len Brown <lenb@...nel.org>, "x86@...nel.org" <x86@...nel.org> CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org> Subject: RE: [PATCH 03/11] x86 topology: Add CPUID.1F multi-die/package support >> @@ -461,7 +463,7 @@ static bool match_llc(struct cpuinfo_x86 *c, struct cpuinfo_x86 *o) >> */ >> static bool match_die(struct cpuinfo_x86 *c, struct cpuinfo_x86 *o) >> { >> - if (c->>phys_proc_id == o->>phys_proc_id) >> + if (c->>cpu_die_id == o->>cpu_die_id) >> return true; >> return false; >> } > Shouldn't we check the unique_die_id here? > Die from different package can have the same cpu_die_id. Good catch. Updated this hunk as below. Thanks! -Len @@ -461,7 +463,8 @@ static bool match_llc(struct cpuinfo_x86 *c, struct cpuinfo_x86 *o) */ static bool match_die(struct cpuinfo_x86 *c, struct cpuinfo_x86 *o) { - if (c->phys_proc_id == o->phys_proc_id) + if ((c->phys_proc_id == o->phys_proc_id) && + (c->cpu_die_id == o->cpu_die_id)) return true; return false; }
Powered by blists - more mailing lists