linux-kernel - Re: [PATCH 0/2] perf evsel: add support for inlined function in callchains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190219193844.GB25535@kernel.org>
Date:   Tue, 19 Feb 2019 16:38:44 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Jonas Rabenstein <jonas.rabenstein@...dium.uni-erlangen.de>,
        Milian Wolff <milian.wolff@...b.com>
Cc:     linux-perf-users@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Andi Kleen <ak@...ux.intel.com>,
        Thomas Richter <tmricht@...ux.ibm.com>,
        Stephane Eranian <eranian@...gle.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] perf evsel: add support for inlined function in
 callchains

Em Tue, Feb 19, 2019 at 07:38:08PM +0100, Jonas Rabenstein escreveu:
> Hi,
> sample__fprintf_callchain currently did not use the already available
> code to get the symbols of an inlined function if such information is
> available in a dso. This patchset adds the required logic to add
> appropriate lines.

You forgot to add the person that did lots of work in this area more
recently, Milian, which I'm adding here so that he have the opportunity
to comment on your work,

Thanks for working on this!

- Arnaldo
 
> As I am quite new to the code base of perf I am not sure how to test
> that changeset in a correct way. At least the codes builds and the tools
> that make use of sample__fprintf_callchain (perf-script, perf-trace and
> perf-sched as far as I can see) did not fail to run - also I did not get
> into the details of perf-trace and perf-sched as I have never used them
> before.
> 
> Another thing I am not sure how to deal with are some warnings of
> checkpatch.pl due to the 80 character line limit. Due to the long
> function names in use the current implementation already exceeded that
> limit in the same spots by even more characters as I have taken the
> inner loop and put it into a separate function.
> 
> I hope to expand my work to perf-report but thought it might be usefull
> to get already early feedback on those patches.
> 
> Thank you,
>  Jonas
> 
> Jonas Rabenstein (2):
>   perf evsel: split sample__fprintf_callchain in output and iteration
>   perf evsel: add inline functions to sample callchain output
> 
>  tools/perf/util/evsel_fprintf.c | 157 ++++++++++++++++++++++----------
>  1 file changed, 109 insertions(+), 48 deletions(-)
> 
> -- 
> 2.19.2

-- 

- Arnaldo