linux-kernel - Re: [PATCH v2 2/2] i2c: designware: Add support for a bus clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 19 Feb 2019 21:25:27 +0100
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Gareth Williams <gareth.williams.jx@...esas.com>
Cc:     Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        linux-i2c@...r.kernel.org,
        Phil Edworthy <phil.edworthy@...esas.com>,
        linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH v2 2/2] i2c: designware: Add support for a bus clock


> -	if (prepare)
> +	if (prepare) {
> +		/* Optional bus clock */
> +		ret = clk_prepare_enable(dev->busclk);
> +		if (ret)
> +			return ret;
> +
>  		return clk_prepare_enable(dev->clk);

This leaves 'busclk' enabled when the other clock fails.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)