lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 Feb 2019 13:19:32 -0800 (PST) From: Paul Walmsley <paul.walmsley@...ive.com> To: Andreas Schwab <schwab@...e.de> cc: Paul Walmsley <paul.walmsley@...ive.com>, linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org, paul@...an.com, palmer@...ive.com, aou@...s.berkeley.edu Subject: Re: [PATCH] arch: riscv: support kernel command line forcing when no DTB passed On Tue, 5 Feb 2019, Andreas Schwab wrote: > On Dez 17 2018, Paul Walmsley <paul.walmsley@...ive.com> wrote: > > > diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c > > index 2c290e6aaa6e..e6b962ff39b1 100644 > > --- a/arch/riscv/kernel/setup.c > > +++ b/arch/riscv/kernel/setup.c > > @@ -171,7 +171,14 @@ asmlinkage void __init setup_vm(void) > > > > void __init parse_dtb(unsigned int hartid, void *dtb) > > { > > - early_init_dt_scan(__va(dtb)); > > + if (!early_init_dt_scan(__va(dtb))) > > + return; > > + > > + pr_err("No DTB passed to the kernel\n"); > > Isn't that backwards? early_init_dt_scan returns true if it found a > DTB. Yes, it's backwards. Thanks for the catch. Looks like I sent an older version of the patch. - Paul
Powered by blists - more mailing lists