linux-kernel - Re: [PATCH] selftests/ftrace: Make the coloring POSIX compliant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190220144934.22c52092@gandalf.local.home>
Date:   Wed, 20 Feb 2019 14:49:34 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Juerg Haefliger <juerg.haefliger@...onical.com>
Cc:     linux-kernel@...r.kernel.org, mingo@...hat.com,
        Juerg Haefliger <juergh@...onical.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Shuah Khan <shuahkhan@...il.com>
Subject: Re: [PATCH] selftests/ftrace: Make the coloring POSIX compliant

On Wed, 20 Feb 2019 17:13:33 +0100
Juerg Haefliger <juerg.haefliger@...onical.com> wrote:

> echo -e and \e are not POSIX. Depending on what /bin/sh is, we can get
> incorrect output like:

I'm curious to which shell this is.

> $ -e -n [1] Basic trace file check
> $ -e 	[PASS]
> 
> Fix that by using \033 instead of \e and printf.
> 
> Signed-off-by: Juerg Haefliger <juergh@...onical.com>
> ---
>  tools/testing/selftests/ftrace/ftracetest | 17 +++++++++++------
>  1 file changed, 11 insertions(+), 6 deletions(-)
> 
> diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
> index fc755e1b50f1..f200898e3e2c 100755
> --- a/tools/testing/selftests/ftrace/ftracetest
> +++ b/tools/testing/selftests/ftrace/ftracetest
> @@ -161,10 +161,10 @@ color_green=
>  color_blue=
>  # If stdout exists and number of colors is eight or more, use them
>  if [ -t 1 -a "$ncolors" -ge 8 ]; then
> -  color_reset="\e[0m"
> -  color_red="\e[31m"
> -  color_green="\e[32m"
> -  color_blue="\e[34m"
> +  color_reset="\033[0m"
> +  color_red="\033[31m"
> +  color_green="\033[32m"
> +  color_blue="\033[34m"
>  fi
>  
>  strip_esc() {
> @@ -173,8 +173,13 @@ strip_esc() {
>  }
>  
>  prlog() { # messages
> -  echo -e "$@"
> -  [ "$LOG_FILE" ] && echo -e "$@" | strip_esc >> $LOG_FILE
> +  newline="\n"
> +  if [ "$1" = "-n" ] ; then
> +    newline=
> +    shift
> +  fi
> +  printf "$@...wline"
> +  [ "$LOG_FILE" ] && printf "$@...wline" | strip_esc >> $LOG_FILE
>  }
>  catlog() { #file
>    cat $1

This should probably be split into two patches, as they are two
different issues.

-- Steve