| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <DB3PR0402MB3916F868BBB10B2898C46026F57D0@DB3PR0402MB3916.eurprd04.prod.outlook.com>
Date: Wed, 20 Feb 2019 03:43:54 +0000
From: Anson Huang <anson.huang@....com>
To: Aisheng Dong <aisheng.dong@....com>,
"robh+dt@...nel.org" <robh+dt@...nel.org>,
"mark.rutland@....com" <mark.rutland@....com>,
"shawnguo@...nel.org" <shawnguo@...nel.org>,
"s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
"kernel@...gutronix.de" <kernel@...gutronix.de>,
"festevam@...il.com" <festevam@...il.com>,
"catalin.marinas@....com" <catalin.marinas@....com>,
"will.deacon@....com" <will.deacon@....com>,
"rui.zhang@...el.com" <rui.zhang@...el.com>,
"edubezval@...il.com" <edubezval@...il.com>,
"daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>,
"ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
Daniel Baluta <daniel.baluta@....com>,
"horms+renesas@...ge.net.au" <horms+renesas@...ge.net.au>,
Andy Gross <andy.gross@...aro.org>,
"heiko@...ech.de" <heiko@...ech.de>,
"arnd@...db.de" <arnd@...db.de>,
"maxime.ripard@...tlin.com" <maxime.ripard@...tlin.com>,
"jagan@...rulasolutions.com" <jagan@...rulasolutions.com>,
"bjorn.andersson@...aro.org" <bjorn.andersson@...aro.org>,
"enric.balletbo@...labora.com" <enric.balletbo@...labora.com>,
"marc.w.gonzalez@...e.fr" <marc.w.gonzalez@...e.fr>,
"olof@...om.net" <olof@...om.net>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>
CC: dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH V6 1/4] dt-bindings: fsl: scu: add thermal binding
Best Regards!
Anson Huang
> -----Original Message-----
> From: Aisheng Dong
> Sent: 2019年2月20日 11:27
> To: Anson Huang <anson.huang@....com>; robh+dt@...nel.org;
> mark.rutland@....com; shawnguo@...nel.org; s.hauer@...gutronix.de;
> kernel@...gutronix.de; festevam@...il.com; catalin.marinas@....com;
> will.deacon@....com; rui.zhang@...el.com; edubezval@...il.com;
> daniel.lezcano@...aro.org; ulf.hansson@...aro.org; Daniel Baluta
> <daniel.baluta@....com>; horms+renesas@...ge.net.au; Andy Gross
> <andy.gross@...aro.org>; heiko@...ech.de; arnd@...db.de;
> maxime.ripard@...tlin.com; jagan@...rulasolutions.com;
> bjorn.andersson@...aro.org; enric.balletbo@...labora.com;
> marc.w.gonzalez@...e.fr; olof@...om.net; devicetree@...r.kernel.org;
> linux-kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
> pm@...r.kernel.org
> Cc: dl-linux-imx <linux-imx@....com>
> Subject: RE: [PATCH V6 1/4] dt-bindings: fsl: scu: add thermal binding
>
> > From: Anson Huang
> > Sent: Thursday, February 7, 2019 5:53 PM
> [...]
> >
> > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as system
> > controller, the system controller is in charge of system power, clock
> > and thermal sensors etc. management, Linux kernel has to communicate
> > with system controller via MU (message unit) IPC to get temperature
> > from thermal sensors, this patch adds binding doc for i.MX system
> controller thermal driver.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@....com>
> > Reviewed-by: Rob Herring <robh@...nel.org>
> > ---
> > ChangeLog since V5:
> > - add "imx,sensor-resource-id" in each thermal zone to pass resource
> > ID for thermal driver.
> > ---
> > .../devicetree/bindings/arm/freescale/fsl,scu.txt | 20
> > ++++++++++++++++++++
> > 1 file changed, 20 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> > b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> > index 72d481c..4b79751 100644
> > --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> > @@ -122,6 +122,20 @@ RTC bindings based on SCU Message Protocol
> > Required properties:
> > - compatible: should be "fsl,imx8qxp-sc-rtc";
> >
> > +Thermal bindings based on SCU Message Protocol
> > +------------------------------------------------------------
> > +
> > +Required properties:
> > +- compatible : Must be "fsl,imx8qxp-sc-thermal";
> > +- tsens-num : Total number of thermal sensors supported;
> > +- #thermal-sensor-cells : Should be 1. See
> > +
> Documentation/devicetree/bindings/thermal/thermal.txt
> > + for a description.
> > +- imx,sensor-resource-id : This property should be defined in each
> > +thermal
> > zone
> > + of thermal-zones node, it passes each thermal
> zone's
> > + resource id for thermal driver to get temperature
> via
> > + SCU IPC.
>
> This is missing in the example?
There are two parts of thermal dts, one is the tsens which are different on each platform.
The other are common thermal-zone definitions, these are covered by thermal binding doc.
The property is added by us for our platforms, if want to put it in example, I need to copy
Hope piece of common thermal-zone node.
>
> BTW, is this SCU function likely platform dependent?
> If not, you probably could add a fallback compatible such as "fsl,scu-rtc"
For now, the SCU API we used are platform independent, the ONLY parameter depends
on platform is resource ID, we can get it from dtb node.
OK, I think we can use a more generic compatible name like "fsl,imx-sc-thermal".
Anson.
>
> Regards
> Dong Aisheng
>
> > +
> > Example (imx8qxp):
> > -------------
> > lsio_mu1: mailbox@...c0000 {
> > @@ -168,6 +182,12 @@ firmware {
> > rtc: rtc {
> > compatible = "fsl,imx8qxp-sc-rtc";
> > };
> > +
> > + tsens: thermal-sensor {
> > + compatible = "fsl,imx8qxp-sc-thermal";
> > + tsens-num = <1>;
> > + #thermal-sensor-cells = <1>;
> > + };
> > };
> > };
> >
> > --
> > 2.7.4
Powered by blists - more mailing lists