lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 20 Feb 2019 14:17:55 +0900 From: "Sugaya, Taichi" <sugaya.taichi@...ionext.com> To: Arnd Bergmann <arnd@...db.de> Cc: Linux ARM <linux-arm-kernel@...ts.infradead.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Shinji Kanematsu <kanematsu.shinji@...ionext.com>, Masami Hiramatsu <masami.hiramatsu@...aro.org>, Russell King <linux@...linux.org.uk>, Jassi Brar <jaswinder.singh@...aro.org>, Takao Orito <orito.takao@...ionext.com>, Kazuhiro Kasai <kasai.kazuhiro@...ionext.com> Subject: Re: [PATCH v2 04/15] ARM: milbeaut: Add basic support for Milbeaut m10v SoC Hi, On 2019/02/19 18:21, Arnd Bergmann wrote: > On Tue, Feb 19, 2019 at 8:12 AM Sugaya, Taichi > <sugaya.taichi@...ionext.com> wrote: >> On 2019/02/18 21:15, Arnd Bergmann wrote: >>> On Fri, Feb 8, 2019 at 1:26 PM Sugaya Taichi >>> <sugaya.taichi@...ionext.com> wrote: >> >>>> +static int __init m10v_pm_init(void) >>>> +{ >>>> + suspend_set_ops(&m10v_pm_ops); >>>> + >>>> + return 0; >>>> +} >>>> +late_initcall(m10v_pm_init); >>> >>> This requires a check to ensure you are actually on the right platform, >>> otherwise you break suspend/resume in a multiplatform kernel running >>> on anything other than milbeaut. >>> >> >> OK. >> I think the solution is adding a "if statement with mlbeaut compatible" >> above suspend_set_ops(&m10v_pm_ops). > > Right, you can either use a call to of_machine_is_compatible(), > or you add a machine descriptor with OF_MACHINE_START() > and use this as the init_late() callback. > Yeah, I will use "of_machine_is_compatible()". Thanks, Sugaya Taichi > Arnd >
Powered by blists - more mailing lists