linux-kernel - Re: [PATCH 4/4] drm/panel: Add OSD101T2587-53TS driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fefcd92c-4171-ed86-28d2-4145d409a73d@ti.com>
Date:   Wed, 20 Feb 2019 12:39:11 +0200
From:   Peter Ujfalusi <peter.ujfalusi@...com>
To:     Sam Ravnborg <sam@...nborg.org>
CC:     <thierry.reding@...il.com>, <airlied@...ux.ie>, <daniel@...ll.ch>,
        <devicetree@...r.kernel.org>, <tomi.valkeinen@...com>,
        <robh+dt@...nel.org>, <linux-kernel@...r.kernel.org>,
        <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH 4/4] drm/panel: Add OSD101T2587-53TS driver

Hi Sam,

On 15/02/2019 20.07, Sam Ravnborg wrote:
>> +#include <linux/backlight.h>
>> +#include <linux/module.h>
>> +#include <linux/of.h>
>> +#include <linux/regulator/consumer.h>
>> +
>> +#include <drm/drmP.h>
> Please do not use drmP.h in new drivers - we try to get rid of this file.

...

>> +static int osd101t2587_panel_get_modes(struct drm_panel *panel)
>> +{
>> +	struct osd101t2587_panel *osd101t2587 = to_osd101t2587_panel(panel);
>> +	struct drm_display_mode *mode;
>> +
>> +	mode = drm_mode_duplicate(panel->drm, osd101t2587->default_mode);
>> +	if (!mode) {
>> +		dev_err(panel->drm->dev, "failed to add mode %ux%ux@%u\n",

drm/drmP.h is needed for this dev_err.

Regards,
- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki