linux-kernel - Re: [PATCH v1 13/24] drivers: thermal: tsens: Print IP version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190220011718.GD2811@localhost.localdomain>
Date:   Tue, 19 Feb 2019 17:17:19 -0800
From:   Eduardo Valentin <edubezval@...il.com>
To:     Amit Kucheria <amit.kucheria@...aro.org>
Cc:     linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        bjorn.andersson@...aro.org, andy.gross@...aro.org,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        David Brown <david.brown@...aro.org>,
        Zhang Rui <rui.zhang@...el.com>, linux-pm@...r.kernel.org
Subject: Re: [PATCH v1 13/24] drivers: thermal: tsens: Print IP version

On Thu, Feb 07, 2019 at 04:19:31PM +0530, Amit Kucheria wrote:
> On some TSENS IP, version is stored. Print that version at init.
> 
> Signed-off-by: Amit Kucheria <amit.kucheria@...aro.org>
> ---
>  drivers/thermal/qcom/tsens-common.c | 23 ++++++++++++++++++++++-
>  1 file changed, 22 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c
> index aae3d71d7eed..39cd5733fd44 100644
> --- a/drivers/thermal/qcom/tsens-common.c
> +++ b/drivers/thermal/qcom/tsens-common.c
> @@ -121,7 +121,7 @@ int __init init_common(struct tsens_priv *priv)
>  	void __iomem *tm_base, *srot_base;
>  	struct device *dev = priv->dev;
>  	struct resource *res;
> -	u32 enabled;
> +	u32 enabled, maj_ver, min_ver;
>  	int ret, i, j;
>  	struct platform_device *op = of_find_device_by_node(priv->dev->of_node);
>  
> @@ -155,6 +155,27 @@ int __init init_common(struct tsens_priv *priv)
>  	if (IS_ERR(priv->tm_map))
>  		return PTR_ERR(priv->tm_map);
>  
> +	for (i = 0; i < MAX_REGFIELDS; i++) {
> +		priv->rf[i] = NULL;
> +	}
> +
> +	/* alloc regmap_fields in srot_map */
> +	if (priv->feat->ver_info) {
> +		for (i = 0, j = VER_MAJOR; i < 2; i++, j++) {
> +			priv->rf[j] = devm_regmap_field_alloc(dev, priv->srot_map,
> +							      priv->fields[j]);
> +			if (IS_ERR(priv->rf[j]))
> +				return PTR_ERR(priv->rf[j]);
> +		}
> +		ret = regmap_field_read(priv->rf[VER_MAJOR], &maj_ver);
> +		if (ret)
> +			return ret;
> +		ret = regmap_field_read(priv->rf[VER_MINOR], &min_ver);
> +		if (ret)
> +			return ret;
> +		dev_info(dev, "version: %d.%d\n", maj_ver, min_ver);

Is this really needed? Printing stuff into kernel log during boot can
just add a lot of info that ends up just slowing down things. Besides,
if this info is important shouldnt be available somewhere else as the
kernel log is a circular buffer and eventually that line will get
wrapped up?

> +	}
> +
>  	priv->rf[TSENS_EN] = devm_regmap_field_alloc(dev, priv->srot_map,
>  						     priv->fields[TSENS_EN]);
>  	if (IS_ERR(priv->rf[TSENS_EN]))
> -- 
> 2.17.1
>