linux-kernel - Re: [PATCH v1] regulator: core: Log forbidden DRMS operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190219163929.GA20883@sirena.org.uk>
Date:   Tue, 19 Feb 2019 16:39:29 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Marc Gonzalez <marc.w.gonzalez@...e.fr>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        MSM <linux-arm-msm@...r.kernel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Jeffrey Hugo <jhugo@...eaurora.org>,
        Evan Green <evgreen@...omium.org>,
        Douglas Anderson <dianders@...omium.org>
Subject: Re: [PATCH v1] regulator: core: Log forbidden DRMS operation

On Tue, Feb 19, 2019 at 05:02:46PM +0100, Marc Gonzalez wrote:
> When REGULATOR_CHANGE_DRMS is not set, drms_uA_update is a no-op.
> It used to print a debug message, which was dropped in commit
> 8a34e979f684 ("regulator: refactor valid_ops_mask checking code")

> Let's bring the debug message back as KERN_INFO, because it is very
> useful to diagnose missing regulator-allow-set-load properties.

No, it's perfectly normal for machine constraints to stop drivers from
doing things so we shouldn't warn on this - it would get incredibly
noisy if we started printing every time constraints didn't let us do
something at info level.  Debug level might be viable, or definitely
vdbg or trace points.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)