lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 20 Feb 2019 15:33:38 +0300
From:   Dan Carpenter <>
To:     YueHaibing <>
Cc:     Chris Mason <>, Josef Bacik <>,
        David Sterba <>,,,
Subject: Re: [PATCH v2 -next] btrfs: Remove unnecessary casts in

On Wed, Feb 20, 2019 at 12:32:02PM +0000, YueHaibing wrote:
> There is a messy cast here:
> 	min_t(int, len, (int)sizeof(*item)));
> min_t() should normally cast to unsigned.  It's not possible for
> "len" to be negative, but if it were then we definitely
> wouldn't want to pass negatives to read_extent_buffer().  Also there
> is an extra cast.
> This patch shouldn't affect runtime, it's just a clean up.
> Suggested-by: Dan Carpenter <>

It wasn't really suggested by me...  But I do think it's the right

Reviewed-by: Dan Carpenter <>

dan carpenter

Powered by blists - more mailing lists