linux-kernel - Re: [PATCH] tools/power turbostat: return the exit status of a command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1365e035-3218-aff5-6d86-05215ce25073@redhat.com>
Date:   Wed, 20 Feb 2019 08:55:31 -0500
From:   David Arcari <darcari@...hat.com>
To:     linux-pm@...r.kernel.org
Cc:     Len Brown <len.brown@...el.com>, Jirka Hladky <jhladky@...hat.com>,
        linux-kernel@...r.kernel.org, Prarit Bhargava <prarit@...hat.com>
Subject: Re: [PATCH] tools/power turbostat: return the exit status of a
 command


ping -- just want to make sure this doesn't get lost.

Thanks!

On 02/12/2019 09:34 AM, David Arcari wrote:
> turbostat failed to return a non-zero exit status even though the
> supplied command (turbostat <command>) failed.  Currently when turbostat
> forks a command it returns zero instead of the actual exit status of the
> command.  Modify the code to return the exit status.
> 
> Signed-off-by: David Arcari <darcari@...hat.com>
> Cc: Len Brown <len.brown@...el.com>
> Cc: Jirka Hladky <jhladky@...hat.com>
> Cc: linux-kernel@...r.kernel.org
> ---
>  tools/power/x86/turbostat/turbostat.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c
> index 9327c0d..c3fad06 100644
> --- a/tools/power/x86/turbostat/turbostat.c
> +++ b/tools/power/x86/turbostat/turbostat.c
> @@ -5077,6 +5077,9 @@ int fork_it(char **argv)
>  		signal(SIGQUIT, SIG_IGN);
>  		if (waitpid(child_pid, &status, 0) == -1)
>  			err(status, "waitpid");
> +
> +		if (WIFEXITED(status))
> +			status = WEXITSTATUS(status);
>  	}
>  	/*
>  	 * n.b. fork_it() does not check for errors from for_all_cpus()
>