linux-kernel - Re: [PATCH] acpi/nfit: Fix bus command validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPcyv4hZXJbrLc9f3xsOTPs_RYVH9vhuxSxHj-4L56ZNi+ZRZg@mail.gmail.com>
Date:   Wed, 20 Feb 2019 08:15:35 -0800
From:   Dan Williams <dan.j.williams@...el.com>
To:     Johannes Thumshirn <jthumshirn@...e.de>
Cc:     Jeff Moyer <jmoyer@...hat.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Vishal Verma <vishal.verma@...el.com>,
        stable <stable@...r.kernel.org>,
        linux-nvdimm <linux-nvdimm@...ts.01.org>
Subject: Re: [PATCH] acpi/nfit: Fix bus command validation

On Wed, Feb 20, 2019 at 12:30 AM Johannes Thumshirn <jthumshirn@...e.de> wrote:
>
> On 20/02/2019 03:58, Dan Williams wrote:
> [...]
>
> >>
> >> Tricky code path, eh?
> >
> > ioctl path, number one source of bugs / thrash in this subsystem. 2nd
> > place, ARS.
>
> Possibly unpopular idea, but should we maybe teach trinity/syzcaller
> about these ioctl()s?
>
> Better we find the bugs in a QA like environment than in the filed, I guess?

I wouldn't be opposed to syzkaller fuzzing the nvdimm-ioctl path.