linux-kernel - Re: [PATCH v2 13/26] mm: export wp_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190221174444.GM2813@redhat.com>
Date:   Thu, 21 Feb 2019 12:44:44 -0500
From:   Jerome Glisse <jglisse@...hat.com>
To:     Peter Xu <peterx@...hat.com>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        David Hildenbrand <david@...hat.com>,
        Hugh Dickins <hughd@...gle.com>,
        Maya Gokhale <gokhale2@...l.gov>,
        Pavel Emelyanov <xemul@...tuozzo.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Martin Cracauer <cracauer@...s.org>, Shaohua Li <shli@...com>,
        Marty McFadden <mcfadden8@...l.gov>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        Denis Plotnikov <dplotnikov@...tuozzo.com>,
        Mike Rapoport <rppt@...ux.vnet.ibm.com>,
        Mel Gorman <mgorman@...e.de>,
        "Kirill A . Shutemov" <kirill@...temov.name>,
        "Dr . David Alan Gilbert" <dgilbert@...hat.com>
Subject: Re: [PATCH v2 13/26] mm: export wp_page_copy()

On Tue, Feb 12, 2019 at 10:56:19AM +0800, Peter Xu wrote:
> Export this function for usages outside page fault handlers.
> 
> Signed-off-by: Peter Xu <peterx@...hat.com>

Reviewed-by: Jérôme Glisse <jglisse@...hat.com>

> ---
>  include/linux/mm.h | 2 ++
>  mm/memory.c        | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index f38fbe9c8bc9..2fd14a62324b 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -405,6 +405,8 @@ struct vm_fault {
>  					 */
>  };
>  
> +vm_fault_t wp_page_copy(struct vm_fault *vmf);
> +
>  /* page entry size for vm->huge_fault() */
>  enum page_entry_size {
>  	PE_SIZE_PTE = 0,
> diff --git a/mm/memory.c b/mm/memory.c
> index f8d83ae16eff..32d32b6e6339 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -2239,7 +2239,7 @@ static inline void wp_page_reuse(struct vm_fault *vmf)
>   *   held to the old page, as well as updating the rmap.
>   * - In any case, unlock the PTL and drop the reference we took to the old page.
>   */
> -static vm_fault_t wp_page_copy(struct vm_fault *vmf)
> +vm_fault_t wp_page_copy(struct vm_fault *vmf)
>  {
>  	struct vm_area_struct *vma = vmf->vma;
>  	struct mm_struct *mm = vma->vm_mm;
> -- 
> 2.17.1
>