linux-kernel - [PATCH] <linux/kernel.h>: drop the gcc-3.3 'const' hack in roundup()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <ec5dcf72-7c3e-3513-af0c-4003ed598854@infradead.org>
Date:   Wed, 20 Feb 2019 19:33:41 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     LKML <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     Matthew Wilcox <willy@...radead.org>
Subject: [PATCH] <linux/kernel.h>: drop the gcc-3.3 'const' hack in roundup()

From: Randy Dunlap <rdunlap@...radead.org>

The single quotation marks around "const" were causing a
documentation markup warning with reST.  Instead of fixing that
warning, just delete that comment line and the gcc-3.3 hack of
using "const" in the roundup() macro since gcc-3.3 is no longer
supported for kernel builds.

I did around 20 different $arch builds with no problems, but
we'll just have to see if this causes problems for anyone else
out there.

Suggested-by: Matthew Wilcox <willy@...radead.org>
Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
---
 include/linux/kernel.h |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

--- lnx-50-rc7.orig/include/linux/kernel.h
+++ lnx-50-rc7/include/linux/kernel.h
@@ -133,12 +133,10 @@
  *
  * Rounds @x up to next multiple of @y. If @y will always be a power
  * of 2, consider using the faster round_up().
- *
- * The `const' here prevents gcc-3.3 from calling __divdi3
  */
 #define roundup(x, y) (					\
 {							\
-	const typeof(y) __y = y;			\
+	typeof(y) __y = y;				\
 	(((x) + (__y - 1)) / __y) * __y;		\
 }							\
 )